[PATCH] Fix a performance problem in gep(gep ...) merging

Quentin Colombet qcolombet at apple.com
Fri Apr 10 13:20:30 PDT 2015


Hi Wei,

Could you upload the context with your patch to ease the review?

Thanks,
-Quentin


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1474
@@ +1473,2 @@
+        if (!isa<Constant>(GO1) || !isa<Constant>(SO1))
+          return nullptr;
----------------
Without the context, this is hard to say whether or not this is true.
In particular, if the new GEP can be folded in an addressing mode, this is good for the register pressure.

http://reviews.llvm.org/D8911

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list