[PATCH] [mips][microMIPSr6] Implement SUB and SUBU instructions

Daniel Sanders daniel.sanders at imgtec.com
Fri Apr 10 09:04:51 PDT 2015


LGTM with a formatting nit


================
Comment at: test/MC/Disassembler/Mips/micromips32r6.txt:18-22
@@ +17,6 @@
+
+# CHECK: sub $3, $4, $5
+0x00 0xa4 0x19 0x90
+
+# CHECK: subu $3, $4, $5
+0x00 0xa4 0x19 0xd0
----------------
Nit: As per D8704, could you use one-per-line formatting?

http://reviews.llvm.org/D8764

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list