[PATCH] [mips][microMIPSr6] Implement ADD, ADDU and ADDIU instructions

Daniel Sanders daniel.sanders at imgtec.com
Fri Apr 10 08:58:07 PDT 2015


LGTM with a couple nits


================
Comment at: test/MC/Disassembler/Mips/micromips32r6.txt:3-10
@@ +2,10 @@
+
+# CHECK: add $3, $4, $5
+0x00 0xa4 0x19 0x10
+
+# CHECK: addiu $3, $4, 1234
+0x30 0x64 0x04 0xd2
+
+# CHECK: addu $3, $4, $5
+0x00 0xa4 0x19 0x50
+
----------------
Nit: I'd prefer one-per-line formatting for new files like so:
  0x00 0xa4 0x19 0x10 # CHECK: add $3, $4, $5
It's mostly because it makes comparing to decode tables a bit easier (because we can trivially sort the file by mnemonic) and helps us verify that the ISA differences in the test are correct. It also makes it consistent with the assembler tests.

At some point, I intend to re-format the others.

================
Comment at: test/MC/Disassembler/Mips/micromips32r6.txt:11
@@ +10,2 @@
+0x00 0xa4 0x19 0x50
+
----------------
Nit: Newline at end of file

http://reviews.llvm.org/D8704

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list