[PATCH] [InstCombine][CodeGenPrep] Create llvm.uadd.with.overflow in CGP.

Sanjoy Das sanjoy at playingwithpointers.com
Thu Apr 9 20:24:24 PDT 2015


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:754-755
@@ +753,4 @@
+/// Return true if any changes were made.
+static bool CombineOverflowCheckIdiom(CmpInst *CI) {
+  auto CombineUAddWithOverflow = [](CmpInst *CI) {
+    Value *A, *B;
----------------
atrick wrote:
> What am I missing here? Are we going to need a lambda somewhere?
This is because I was going to add a `CombineSAddWithOverflow` (a separate lambda) in the future.  Right now this is not required, and I'll remove it.

http://reviews.llvm.org/D8889

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list