[PATCH] [InstCombine][CodeGenPrep] Create llvm.uadd.with.overflow in CGP.

Sanjoy Das sanjoy at playingwithpointers.com
Thu Apr 9 18:48:40 PDT 2015


gentle ping.

On Tue, Apr 7, 2015 at 11:36 PM, Sanjoy Das
<sanjoy at playingwithpointers.com> wrote:
> Address Andy's review:
>
> - do the transform only if the call to `uadd.with.overflow` can be inserted in the same basic block as the compare.  This prevents us from moving flag-producing instructions.
> - try sinking an icmp before trying to combine it.
> - add test cases that exercise both of the above.
>
>
> http://reviews.llvm.org/D8889
>
> Files:
>   include/llvm/IR/PatternMatch.h
>   lib/CodeGen/CodeGenPrepare.cpp
>   lib/Transforms/InstCombine/InstCombineCompares.cpp
>   test/CodeGen/X86/add-of-carry.ll
>   test/Transforms/CodeGenPrepare/overflow-intrinsics.ll
>   test/Transforms/InstCombine/overflow.ll
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/



More information about the llvm-commits mailing list