[PATCH] [AArch64] Add support for dynamically aligning stack objects

Kristof Beyls kristof.beyls at arm.com
Wed Apr 8 11:00:28 PDT 2015


Thanks for the quick review and nice catches.
It's indeed better to use AND instead of BFI; the patch now does this. It also makes some of the logic a bit simpler - but doesn't reduce the number of instructions needed when a base pointer is also needed, which is when there are both VLAs and dynamically aligned local variables.
I've also added the asserts you indicated - indeed they are good to have.


http://reviews.llvm.org/D8876

Files:
  lib/Target/AArch64/AArch64FrameLowering.cpp
  lib/Target/AArch64/AArch64FrameLowering.h
  lib/Target/AArch64/AArch64RegisterInfo.cpp
  lib/Target/AArch64/AArch64RegisterInfo.h
  test/CodeGen/AArch64/aarch64-dynamic-stack-layout.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8876.23429.patch
Type: text/x-patch
Size: 35965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150408/9dcd2d3a/attachment.bin>


More information about the llvm-commits mailing list