[PATCH] [mips] [IAS] Add support for the .insn directive.

Toma Tabacu toma.tabacu at imgtec.com
Wed Apr 8 08:20:28 PDT 2015


Replied to review inline comment.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFStreamer.cpp:39-40
@@ +38,4 @@
+    markLabelsAsMicroMips();
+  else
+    Labels.clear();
+}
----------------
dsanders wrote:
> We should unconditionally clear Labels as the previous code did. We don't need to mark the same labels multiple times.
Labels actually is unconditionally cleared: in markLabelsAsMicroMips() for the if and directly for the else.

http://reviews.llvm.org/D8006

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list