[lld] r234368 - Remove unused vectors from FileArchive.

Rui Ueyama ruiu at google.com
Tue Apr 7 15:32:19 PDT 2015


Author: ruiu
Date: Tue Apr  7 17:32:19 2015
New Revision: 234368

URL: http://llvm.org/viewvc/llvm-project?rev=234368&view=rev
Log:
Remove unused vectors from FileArchive.

Archive files don't have any symbols (their members do).
The vectors deleted here were always empty.

Modified:
    lld/trunk/lib/ReaderWriter/FileArchive.cpp

Modified: lld/trunk/lib/ReaderWriter/FileArchive.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/FileArchive.cpp?rev=234368&r1=234367&r2=234368&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/FileArchive.cpp (original)
+++ lld/trunk/lib/ReaderWriter/FileArchive.cpp Tue Apr  7 17:32:19 2015
@@ -120,19 +120,19 @@ public:
   }
 
   const atom_collection<DefinedAtom> &defined() const override {
-    return _definedAtoms;
+    return _noDefinedAtoms;
   }
 
   const atom_collection<UndefinedAtom> &undefined() const override {
-    return _undefinedAtoms;
+    return _noUndefinedAtoms;
   }
 
   const atom_collection<SharedLibraryAtom> &sharedLibrary() const override {
-    return _sharedLibraryAtoms;
+    return _noSharedLibraryAtoms;
   }
 
   const atom_collection<AbsoluteAtom> &absolute() const override {
-    return _absoluteAtoms;
+    return _noAbsoluteAtoms;
   }
 
   /// Returns a set of all defined symbols in the archive.
@@ -251,10 +251,6 @@ private:
   std::unique_ptr<Archive> _archive;
   MemberMap _symbolMemberMap;
   InstantiatedSet _membersInstantiated;
-  atom_collection_vector<DefinedAtom> _definedAtoms;
-  atom_collection_vector<UndefinedAtom> _undefinedAtoms;
-  atom_collection_vector<SharedLibraryAtom> _sharedLibraryAtoms;
-  atom_collection_vector<AbsoluteAtom> _absoluteAtoms;
   bool _logLoading;
   std::vector<std::unique_ptr<MemoryBuffer>> _memberBuffers;
   std::map<const char *, std::unique_ptr<Future<File *>>> _preloaded;





More information about the llvm-commits mailing list