[PATCH] Add invoke of llvm.donothing to outlined catch and cleanup handlers to identify their personality

Andy Kaylor andrew.kaylor at intel.com
Tue Apr 7 12:24:38 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:1198
@@ +1197,3 @@
+  // eh.endcatch.  We can just ignore that instruction.
+  // FIXME: There will be a problem with a catch-all handler and cleanup
+  // code in the same block.
----------------
After thinking about this a little more, I think this comment is misplaced.  I believe the cleanup code will always precede the catch code if they are in the same block, and the cleanup handler will stop cloning when it sees eh.begincatch.  The cleanup code may be duplicated in the catch handler.

In any event, I'm going to delete this FIXME comment and see if I can create a test case.

http://reviews.llvm.org/D8835

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list