[PATCH] Disable Mac OS crash reporter in unittests

Justin Bogner mail at justinbogner.com
Tue Apr 7 11:46:04 PDT 2015


Reid Kleckner <rnk at google.com> writes:
> We already do this in llvm::sys::PrintStackTraceOnErrorSignal. You could
> setenv("LLVM_DISABLE_CRASH_REPORT", "1") to get this behavior.
>
> Either way is probably fine.

Sure, but it makes sense to do this unconditionally in the unit tests.
Crash reports for unit tests (especially death tests) are never useful.

Pete, this LGTM, but please clang-format it before committing. The
arguments to task_set_exception_ports are indented oddly.

> On Tue, Apr 7, 2015 at 11:21 AM, Pete Cooper <peter_cooper at apple.com> wrote:
>> Hi Justin
>>
>> Please review this patch which disables the crash reporter in the unit
>> tests.  This makes tests using EXPECT_DEATH stop taking an unreasonably
>> long time to run.  For example:
>>
>> [----------] 47 tests from APFloatTest (51250 ms total)
>>
>> to
>>
>> [----------] 47 tests from APFloatTest (765 ms total)
>>
>> Cheers,
>> Pete




More information about the llvm-commits mailing list