[llvm] r234247 - [lit] Skip gtest names starting with DISABLED_

Reid Kleckner reid at kleckner.net
Mon Apr 6 15:16:58 PDT 2015


Author: rnk
Date: Mon Apr  6 17:16:58 2015
New Revision: 234247

URL: http://llvm.org/viewvc/llvm-project?rev=234247&view=rev
Log:
[lit] Skip gtest names starting with DISABLED_

The sanitizer test suite uses this idiom to disable a test.  Now that we
actually check if a test ran after invoking it, we see that zero tests
ran, and complain.

Instead, ignore tests starting with DISABLED_ completely. Fixes the
sanitizer test suite failures on Windows.

Modified:
    llvm/trunk/utils/lit/lit/formats/googletest.py

Modified: llvm/trunk/utils/lit/lit/formats/googletest.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/formats/googletest.py?rev=234247&r1=234246&r2=234247&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/formats/googletest.py (original)
+++ llvm/trunk/utils/lit/lit/formats/googletest.py Mon Apr  6 17:16:58 2015
@@ -53,6 +53,10 @@ class GoogleTest(TestFormat):
             ln = ln[index*2:]
             if ln.endswith('.'):
                 nested_tests.append(ln)
+            elif ln.startswith('DISABLED_'):
+                # Gtest will internally skip these tests. No need to launch a
+                # child process for it.
+                continue
             else:
                 yield ''.join(nested_tests) + ln
 





More information about the llvm-commits mailing list