[PATCH] Add invoke of llvm.donothing to outlined catch and cleanup handlers to identify their personality

Reid Kleckner rnk at google.com
Mon Apr 6 13:42:39 PDT 2015


lgtm


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:770
@@ +769,3 @@
+                                        Value *PersonalityFn) {
+  // FIXME: Finish this!
+  LLVMContext &Context = Handler->getContext();
----------------
Do you think more work is necessary here? Unreachable seems like a reasonable thing to do.

http://reviews.llvm.org/D8835

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list