[PATCH] Replace the `createImplicitFiles` method return type with `void`

Simon Atanasyan simon at atanasyan.com
Mon Apr 6 08:34:43 PDT 2015


Hi ruiu, shankar.easwaran, kledzik,

All instances of the `createImplicitFiles` always return `true` and this return value is used nowhere. The patch changes return type from `bool` to `void`.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8842

Files:
  include/lld/Core/LinkingContext.h
  include/lld/Core/Writer.h
  include/lld/ReaderWriter/MachOLinkingContext.h
  include/lld/ReaderWriter/PECOFFLinkingContext.h
  lib/Core/LinkingContext.cpp
  lib/Core/Writer.cpp
  lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
  lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h
  lib/ReaderWriter/ELF/ARM/ARMExecutableWriter.h
  lib/ReaderWriter/ELF/DynamicLibraryWriter.h
  lib/ReaderWriter/ELF/ExecutableWriter.h
  lib/ReaderWriter/ELF/Hexagon/HexagonDynamicLibraryWriter.h
  lib/ReaderWriter/ELF/Hexagon/HexagonExecutableWriter.h
  lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
  lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
  lib/ReaderWriter/ELF/OutputELFWriter.h
  lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h
  lib/ReaderWriter/ELF/X86/X86ExecutableWriter.h
  lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h
  lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h
  lib/ReaderWriter/MachO/MachOLinkingContext.cpp
  lib/ReaderWriter/MachO/WriterMachO.cpp
  lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8842.23275.patch
Type: text/x-patch
Size: 20455 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150406/57d2dd1f/attachment.bin>


More information about the llvm-commits mailing list