[PATCH] Set da-delinearize=true by default

[Hal Finkel]

So long as Karthik is not aware of any correctness issues, then that's fine by me. The patch needs a regression test, however.

 -Hal

----- Original Message -----
> From: "KARTHIK VENKATESH BHAT" <kv.bhat at samsung.com>
> To: "Ana Pazos" <apazos at codeaurora.org>, "llvm commits" <llvm-commits at cs.uiuc.edu>
> Cc: "Hal Finkel" <hfinkel at anl.gov>
> Sent: Monday, April 6, 2015 1:54:42 AM
> Subject: Re: [PATCH]  Set da-delinearize=true by default
> 
> 
> 
> Hi Ana,
> 
> There are few issues in LoopInterchange which I'm working on so
> LoopInterchange is disabled by default. Hopefully those issues will
> be resolved shortly.
> 
> But as Hal and others had mentioned on mailing list some time back we
> will need to delinearize array references to do a correct data
> dependence analysis. So I'm OK with this change but will let more
> experienced people to give a LGTM.
> 
> Thanks and Regards
> 
> Karthik Bhat
> 
> 
> 
> ------- Original Message -------
> 
> Sender : Ana Pazos<apazos at codeaurora.org>
> 
> Date : Apr 03, 2015 02:54 (GMT+09:00)
> 
> Title : [PATCH] Set da-delinearize=true by default
> 
> 
> 
> 
> We now have a client for dependence analysis: LoopInterchange.
> 
> 
> 
> This pass would benefit from having the delinearization flag set to
> true. The default value is false.
> 
> 
> 
> Are the pass issues fixed? Can we change the default to true?
> 
> 
> 
> Thanks,
> 
> Ana.
> 
> 
> 
> diff --git a/lib/Analysis/DependenceAnalysis.cpp
> b/lib/Analysis/DependenceAnalysis.cpp
> 
> index 3374b48..a8d162d 100644
> 
> --- a/lib/Analysis/DependenceAnalysis.cpp
> 
> +++ b/lib/Analysis/DependenceAnalysis.cpp
> 
> @@ -108,7 +108,7 @@ STATISTIC(BanerjeeIndependence, "Banerjee
> independence");
> 
> STATISTIC(BanerjeeSuccesses, "Banerjee successes");
> 
> 
> 
> static cl::opt<bool>
> 
> -Delinearize("da-delinearize", cl::init(false), cl::Hidden,
> cl::ZeroOrMore,
> 
> +Delinearize("da-delinearize", cl::init(true), cl::Hidden,
> cl::ZeroOrMore,
> 
> cl::desc("Try to delinearize array references."));
> 
> 
> 
> 
> 
> Ana Pazos
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> a Linux Foundation Collaborative Project.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 	
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory