[PATCH] [X86, SSE] instcombine common cases of insertps intrinsics into shuffles

David Majnemer david.majnemer at gmail.com
Sat Apr 4 14:28:34 PDT 2015


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:202
@@ +201,3 @@
+                                  InstCombiner::BuilderTy &Builder) {
+  if (auto CInt = dyn_cast<ConstantInt>(II.getArgOperand(2))) {
+    VectorType *VecTy = cast<VectorType>(II.getType());
----------------
please make this `auto *CInt` so that it is more obvious that `CInt` is a pointer.

http://reviews.llvm.org/D8833

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list