[PATCH] [GlobalMerge] Look at uses to create smaller global sets.

[Eric Christopher]

Hi Ahmed,

I think this is starting to look pretty good. A request for a nice big comment with the algorithm as a block comment somewhere in the file? Makes it a bit more hard to suss out what you're doing in some cases. One silly comment inline as well.

Thanks and sorry for the delay!

-eric


================
Comment at: lib/CodeGen/GlobalMerge.cpp:187
@@ +186,3 @@
+  // If we want to just blindly group everything together, do so.
+  if (!EnableGlobalMergeGroupByUse) {
+    BitVector AllGlobals(Globals.size());
----------------
I find the "Enable" here actively hurts my readability on this code, seems to work better without, but up to you.

http://reviews.llvm.org/D8070

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/