[PATCH] LLD: ELF: Remove partial class definitions of <Arch>LinkingContexts.

Rui Ueyama ruiu at google.com
Wed Apr 1 21:45:50 PDT 2015


Hi garious,

What we are doing in ELFTarget.h is dubious. In the file, we define
partial classes of <Arch>LinkingContexts to declare only a static member
function. We have different (complete) class definitions in other headers.
They would conflict if they exist in the same compilation unit (because
the ones defined in ELFTarget.h has only static member functions).
I don't think this is valid in C++.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8797

Files:
  include/lld/ReaderWriter/ELFTargets.h
  lib/Driver/GnuLdDriver.cpp
  lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.cpp
  lib/ReaderWriter/ELF/ARM/ARMLinkingContext.cpp
  lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.cpp
  lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp
  lib/ReaderWriter/ELF/X86/X86LinkingContext.cpp
  lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleLinkingContext.cpp
  lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8797.23117.patch
Type: text/x-patch
Size: 7399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150402/42e570c0/attachment.bin>


More information about the llvm-commits mailing list