[PATCH] Add support for lldb remote test

Siva Chandra sivachandra at google.com
Wed Apr 1 16:39:29 PDT 2015


LGTM to avoid another round trip. But please address comments before submitting.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:14
@@ -13,2 +13,3 @@
 from zorg.buildbot.builders.Util import extractSlaveEnvironment
+import json
 
----------------
Nit: This is standard library module. Should be above 'import os' at line #1.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:312
@@ +311,3 @@
+               'remote_port' : remote_config['port'],
+               'remote_dir' : remote_config['dir']}
+    f.addStep(SetProperty(name="get remote target",
----------------
The JSON file itself should have keys 'remote_host', 'remote_port', and 'remote_dir'. You just do this:

    return json.loads(stdout)

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:369
@@ -251,3 +368,3 @@
             *args,
             **kwargs):
 
----------------
Nit (repeating from last time): Fix the indentation of the params to align to the opening '('.

http://reviews.llvm.org/D8711

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list