[PATCH] [mips][microMIPSr6] Implement initial subtarget support

Daniel Sanders daniel.sanders at imgtec.com
Wed Apr 1 11:38:18 PDT 2015


LGTM with a couple nits.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp:134
@@ -130,1 +133,3 @@
+  if (IsLittleEndian && Size == 4 &&
+      (isMicroMips(STI) || isMicroMips32r6(STI))) {
     EmitInstruction(Val >> 16, 2, STI, OS);
----------------
Do we need to check both here? I'd expect isMicroMips(STI) to be true for all revisions of microMIPS like the way hasMips32() is true when Mips32r6() is true.

================
Comment at: lib/Target/Mips/MipsInstrInfo.td:186
@@ -185,1 +185,3 @@
+def HasMicroMips32r6 : Predicate<"Subtarget->inMicroMips32r6Mode()">,
+                      AssemblerPredicate<"FeatureMicroMips32r6">;
 def InMips16Mode :    Predicate<"Subtarget->inMips16Mode()">,
----------------
Nit: indentation

http://reviews.llvm.org/D8386

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list