[PATCH] [Sanitizers Coverage] Make sancov.py work with wildcards from Windows CMD shell

Timur Iskhodzhanov timurrrr at google.com
Wed Apr 1 07:48:29 PDT 2015


================
Comment at: lib/sanitizer_common/scripts/sancov.py:187
@@ +186,3 @@
+  for f in sys.argv[2:]:
+    if f.find("*") != -1:
+      file_list += glob.glob(f)
----------------
kcc wrote:
> What about '?'
> Why not run glob unconditionally. 
Good point, will do.

================
Comment at: lib/sanitizer_common/scripts/sancov.py:195
@@ -184,3 +194,3 @@
   if sys.argv[1] == "print":
-    PrintFiles(sys.argv[2:])
+    PrintFiles(file_list, bits)
   elif sys.argv[1] == "merge":
----------------
the "`, bits`" part is a merge conflict inflicted mistake indeed/
Will fix

http://reviews.llvm.org/D8724

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list