[PATCH] Implementation of R_ARM_TARGET1

Denis Protivensky dprotivensky at accesssoftek.com
Wed Apr 1 00:18:57 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Driver/GnuLdDriver.cpp:549
@@ +548,3 @@
+  bool hasArmTarget1Abs = parsedArgs->hasArg(OPT_arm_target1_abs);
+  if (hasArmTarget1Rel || hasArmTarget1Abs) {
+    if (triple.getArch() == llvm::Triple::arm) {
----------------
You can remove this outermost `if (hasArmTarget1Rel || hasArmTarget1Abs)` check completely because it doesn't introduce any logic. All the cases are double-checked inside it.

http://reviews.llvm.org/D8707

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list