[PATCH] Fix WinEHPrepare bug with multiple catch handlers

Reid Kleckner rnk at google.com
Tue Mar 31 16:06:37 PDT 2015


LGTM with the `#if 0` code removed. The promotion seems like a nice simplification. :)


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:371
@@ +370,3 @@
+void WinEHPrepare::getAnalysisUsage(AnalysisUsage &AU) const {
+  AU.addRequired<DominatorTreeWrapperPass>();
+}
----------------
My understanding is that you are also required to change the INITIALIZE_TM_PASS code to use INITIALIZE_TM_PASS_BEGIN / END and INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass). See DwarfEHPrepare. I could be wrong, the pass registry stuff is all ugly goo that will hopefully be removed when the new pass manager happens.

http://reviews.llvm.org/D8682

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list