[PATCH] Implementation of R_ARM_TARGET1

Leny Kholodov leny.kholodov at gmail.com
Tue Mar 31 11:31:09 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.h:26
@@ +25,3 @@
+                             ARMLinkingContext &context)
+      : _armLayout(layout),
+        _armContext(context) {}
----------------
lenykholodov wrote:
> ruiu wrote:
> > Remove newline after comma.
> > 
> > Maybe you want to pass a boolean value instead of a context object itself? That makes it clear that you only need the boolean flag.
> You are right. Will be fixed.
Unfortunately, the ARMRelocationHandler class initializes before the command line arguments parsing. So when I'm passing bool variable to the ARMRelocationHandler construtor, this variable contains only a default value. I've rewritten the code. Now it retrieves ELFLinkingContext through _armLayout field which has been already added to the class ARMRelocationHandler before my patch and has access to the ELFLinkingContext.

http://reviews.llvm.org/D8707

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list