[PATCH] Add support for lldb remote test

Ying Chen chying at google.com
Mon Mar 30 16:10:43 PDT 2015


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:295
@@ +294,3 @@
+                                     workdir='%s' % llvm_builddir))
+            f=cleanSVNSourceTree(f, '%s/tools/lldb' % llvm_srcdir)
+    # terminate lldb-server on remote host
----------------
sivachandra wrote:
> Lines 272-295 and lines 385-406 should probably live in a common function.
Yes, I will re-factor the code.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:376
@@ -301,1 +375,3 @@
+                          remote_test_compilers,
+                          env)
     # Skip lldb-test if no test compiler or arch is specified
----------------
sivachandra wrote:
> The remote test steps should probably be added after the local test steps? That is, after line 406?
I put it here, to avoid making changes to 378-379
But I will re-factor the code as suggested above.

http://reviews.llvm.org/D8711

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list