[llvm] r233600 - Explain how to abandon a review.

[Paul Robinson]

Author: probinson
Date: Mon Mar 30 16:27:28 2015
New Revision: 233600

URL: http://llvm.org/viewvc/llvm-project?rev=233600&view=rev
Log:
Explain how to abandon a review.

Modified:
    llvm/trunk/docs/Phabricator.rst

Modified: llvm/trunk/docs/Phabricator.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/Phabricator.rst?rev=233600&r1=233599&r2=233600&view=diff
==============================================================================
--- llvm/trunk/docs/Phabricator.rst (original)
+++ llvm/trunk/docs/Phabricator.rst Mon Mar 30 16:27:28 2015
@@ -85,8 +85,11 @@ Reviewing code with Phabricator
 Phabricator allows you to add inline comments as well as overall comments
 to a revision. To add an inline comment, select the lines of code you want
 to comment on by clicking and dragging the line numbers in the diff pane.
+When you have added all your comments, scroll to the bottom of the page and
+click the Submit button.
 
-You can add overall comments or submit your comments at the bottom of the page.
+You can add overall comments in the text box at the bottom of the page.
+When you're done, click the Submit button.
 
 Phabricator has many useful features, for example allowing you to select
 diffs between different versions of the patch as it was reviewed in the
@@ -128,6 +131,16 @@ This allows people reading the version h
 context.  This also allows Phabricator to detect the commit, close the
 review, and add a link from the review to the commit.
 
+Abandoning a change
+-------------------
+
+If you decide you should not commit the patch, you should explicitly abandon
+the review so that reviewers don't think it is still open. In the web UI,
+scroll to the bottom of the page where normally you would enter an overall
+comment. In the drop-down Action list, which defaults to "Comment," you should
+select "Abandon Revision" and then enter a comment explaining why. Click the
+Submit button to finish closing the review.
+
 Status
 ------