[PATCH] DFSan-based fuzzer (proof of concept).

Alexey Samsonov vonosmas at gmail.com
Mon Mar 30 13:03:46 PDT 2015


LGTM for CMake part (but note comment about explicit dependency on abilist you may require).


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:21
@@ -20,3 +24,2 @@
   add_executable(LLVMFuzzer-${Test}
-    EXCLUDE_FROM_ALL
     ${Test}.cpp
----------------
Did you remove this line on purpose?

================
Comment at: lib/Fuzzer/test/dfsan/CMakeLists.txt:10
@@ +9,3 @@
+    )
+  target_link_libraries(LLVMFuzzer-${Test}
+    LLVMFuzzer
----------------
You probably need smth. like
  set(DFSAN_FUZZER_ABI_LIST "${CMAKE_CURRENT_SOURCE_DIR}/../../dfsan_fuzzer_abi.list")
  ...

  set_source_files_properties(${Test}.cpp PROPERTIES OBJECT_DEPENDS ${DFSAN_FUZZER_ABI_LIST})

to make sure you will recompile the test after changes to ABI list.

http://reviews.llvm.org/D8669

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list