[PATCH] Disable passes on optnone functions

[David Blaikie]

The little "comment" dropdown above the comment box (the one at the bottom
of the review, after all the diff changes) has an "abandon" option, which I
think is what we're doing for code reviews that end up not going anywhere.

(there's also a "close" option too, I'm not sure of the distinction)

Maybe we should be using whatever feature this refers to:
https://secure.phabricator.com/T4720 so that we can all just mark code
reviews as abandoned, rather than requesting the original author do so.

On Sun, Mar 29, 2015 at 11:16 PM, Paul Robinson <
Paul_Robinson at playstation.sony.com> wrote:

> In http://reviews.llvm.org/D2369#148431, @chandlerc wrote:
>
> > Pretty sure this is obsolete.
>
>
> Well, ultimately the revised content of this patch landed in r200892.  The
> email record exists if you want to look at it, circa Feb 5 2014.
> But by that time it was clear Phabricator hated me and I had stopped
> trying to do anything with it.
> More recently I've been persuaded to try it again, and a few basic things
> do seem to work okay.
>
> Phab's "help" is astoundingly un-helpful.  If there's something you
> actually want me to _do_ here, please (a) point me to a Phab help page that
> describes it, or (b) explain in enough detail that I can document it on
> LLVM's Phab page.
> Thanks,
> --paulr
>
>
> http://reviews.llvm.org/D2369
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150330/03f313dd/attachment.html>