[PATCH] [UBSan] Embed UBSan into ASan runtime (compiler-rt part).

Yury Gribov tetra2005 at gmail.com
Mon Mar 30 05:06:41 PDT 2015


================
Comment at: lib/ubsan/ubsan_init.cc:52
@@ +51,3 @@
+  SpinMutexLock l(&ubsan_init_mu);
+  CHECK_NE(UBSAN_MODE_PLUGIN, ubsan_mode);
+  if (ubsan_mode == UBSAN_MODE_UNKNOWN)
----------------
Note that this will probably break GCC's dynamic UBSan runtime (e.g. when one part of the app is A-sanitized and another is UB-sanitized).

================
Comment at: make/platform/clang_darwin.mk:279
@@ -279,1 +278,3 @@
+                              $(AsanDynamicFunctions) \
+															$(UbsanFunctions) $(UbsanCXXFunctions)
 
----------------
Looks like you use tabs here and below which is inconsistent with existing code.

http://reviews.llvm.org/D8646

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list