[PATCH] Strip constant factors from parameters

[Johannes Doerfert]

Thanks, commited in r233501.

On 03/29, Tobias Grosser wrote:
> Hi Johannes,
> 
> this LGTM. I added some minor comments.
> 
> Tobias
> 
> 
> ================
> Comment at: include/polly/Support/SCEVValidator.h:55
> @@ +54,3 @@
> +
> +/// @brief Extract the constant factors from the multiplaction @p M.
> +///
> ----------------
> multiplication
> 
> ================
> Comment at: include/polly/Support/SCEVValidator.h:57
> @@ +56,3 @@
> +///
> +/// @param M  A SCEV multipilcation.
> +/// @param SE The ScalarEvolution analysis to create new SCEVs.
> ----------------
> multiplication
> 
> ================
> Comment at: lib/Analysis/ScopInfo.cpp:201
> @@ -213,1 +200,3 @@
> +  return isl_pw_aff_mul(visit(ConstantAndLeftOverPair.first),
> +                        visit(ConstantAndLeftOverPair.second));
>  }
> ----------------
> Maybe it is worth to adding a comment that explains why we can not get an infinitive recursion here, where ConstantAndLeftOverPair.second always contains a multiplication and on which we call visitMulExpr again. (The answer seems to be that in visit(Expr) we should stop and realize that the multiplication expression is a parameter expression.)
> 
> ================
> Comment at: test/ScopInfo/constant_factor_in_parameter.ll:4
> @@ +3,3 @@
> +; Check that the constant part of the N * M * 4 expression is not part of the
> +; parameter but explicit in the access function. This can avoid existenially
> +; quantified variables, e.g., when computing the stride.
> ----------------
> existentially
> 
> http://reviews.llvm.org/D8692
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 

-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.31

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150329/976af092/attachment.sig>