[lld] r233401 - Rename all caps class names.

Sean Silva chisophugis at gmail.com
Fri Mar 27 18:12:33 PDT 2015 

On Fri, Mar 27, 2015 at 6:09 PM, Rui Ueyama <ruiu at google.com> wrote:

> On Fri, Mar 27, 2015 at 6:06 PM, Sean Silva <chisophugis at gmail.com> wrote:
>
>>
>>
>> On Fri, Mar 27, 2015 at 12:33 PM, Rui Ueyama <ruiu at google.com> wrote:
>>
>>> Author: ruiu
>>> Date: Fri Mar 27 14:33:05 2015
>>> New Revision: 233401
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=233401&view=rev
>>> Log:
>>> Rename all caps class names.
>>>
>>> We have GOTAtom and PLTAtom classes because GOT or PLT are acronyms.
>>> "Dynamic offset table" or "dynamic" are not acronyms.
>>>
>>
>> They are the names of the symbols though, right? E.g. DYNAMICAtom is not
>> just a "dynamic atom" it is the atom for _DYNAMIC.
>>
>
> Yes they are. You prefer DYNAMICAtom over DynamicAtom?
>

I sort of prefer having it be clear that "dynamic" is not meant in any
generic sense. For GLOBAL_OFFSET_TABLE it doesn't matter as much.

Either way, I don't care very much, since it is obvious from the
"getName()" what they are.

-- Sean Silva


>
>
>>
>> -- Sean Silva
>>
>>
>>>
>>> Modified:
>>>     lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
>>>     lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h
>>>     lld/trunk/lib/ReaderWriter/ELF/Atoms.h
>>>     lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h
>>>     lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h
>>>     lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h
>>>
>>> Modified:
>>> lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
>>> (original)
>>> +++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h
>>> Fri Mar 27 14:33:05 2015
>>> @@ -56,8 +56,8 @@ template <class ELFT>
>>>  bool AArch64DynamicLibraryWriter<ELFT>::createImplicitFiles(
>>>      std::vector<std::unique_ptr<File>> &result) {
>>>    DynamicLibraryWriter<ELFT>::createImplicitFiles(result);
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GLOBAL_OFFSET_TABLEAtom(*_gotFile));
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GlobalOffsetTableAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
>>>    result.push_back(std::move(_gotFile));
>>>    return true;
>>>  }
>>>
>>> Modified:
>>> lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h?rev=233401&r1=233400&r2=233401&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h
>>> (original)
>>> +++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h Fri
>>> Mar 27 14:33:05 2015
>>> @@ -55,9 +55,9 @@ template <class ELFT>
>>>  bool AArch64ExecutableWriter<ELFT>::createImplicitFiles(
>>>      std::vector<std::unique_ptr<File>> &result) {
>>>    ExecutableWriter<ELFT>::createImplicitFiles(result);
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GLOBAL_OFFSET_TABLEAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GlobalOffsetTableAtom(*_gotFile));
>>>    if (_ctx.isDynamic())
>>> -    _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));
>>> +    _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
>>>    result.push_back(std::move(_gotFile));
>>>    return true;
>>>  }
>>>
>>> Modified: lld/trunk/lib/ReaderWriter/ELF/Atoms.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Atoms.h?rev=233401&r1=233400&r2=233401&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/ELF/Atoms.h (original)
>>> +++ lld/trunk/lib/ReaderWriter/ELF/Atoms.h Fri Mar 27 14:33:05 2015
>>> @@ -781,9 +781,9 @@ public:
>>>    }
>>>  };
>>>
>>> -class GLOBAL_OFFSET_TABLEAtom : public SimpleELFDefinedAtom {
>>> +class GlobalOffsetTableAtom : public SimpleELFDefinedAtom {
>>>  public:
>>> -  GLOBAL_OFFSET_TABLEAtom(const File &f) : SimpleELFDefinedAtom(f) {}
>>> +  GlobalOffsetTableAtom(const File &f) : SimpleELFDefinedAtom(f) {}
>>>
>>>    StringRef name() const override { return "_GLOBAL_OFFSET_TABLE_"; }
>>>
>>> @@ -804,9 +804,9 @@ public:
>>>    ArrayRef<uint8_t> rawContent() const override { return
>>> ArrayRef<uint8_t>(); }
>>>  };
>>>
>>> -class DYNAMICAtom : public SimpleELFDefinedAtom {
>>> +class DynamicAtom : public SimpleELFDefinedAtom {
>>>  public:
>>> -  DYNAMICAtom(const File &f) : SimpleELFDefinedAtom(f) {}
>>> +  DynamicAtom(const File &f) : SimpleELFDefinedAtom(f) {}
>>>
>>>    StringRef name() const override { return "_DYNAMIC"; }
>>>
>>>
>>> Modified: lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h
>>> (original)
>>> +++ lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h Fri Mar
>>> 27 14:33:05 2015
>>> @@ -55,8 +55,8 @@ template <class ELFT>
>>>  bool X86DynamicLibraryWriter<ELFT>::createImplicitFiles(
>>>      std::vector<std::unique_ptr<File>> &result) {
>>>    DynamicLibraryWriter<ELFT>::createImplicitFiles(result);
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GLOBAL_OFFSET_TABLEAtom(*_gotFile));
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GlobalOffsetTableAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
>>>    result.push_back(std::move(_gotFile));
>>>    return true;
>>>  }
>>>
>>> Modified:
>>> lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h
>>> (original)
>>> +++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h
>>> Fri Mar 27 14:33:05 2015
>>> @@ -51,8 +51,8 @@ X86_64DynamicLibraryWriter::X86_64Dynami
>>>  bool X86_64DynamicLibraryWriter::createImplicitFiles(
>>>      std::vector<std::unique_ptr<File>> &result) {
>>>    DynamicLibraryWriter::createImplicitFiles(result);
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GLOBAL_OFFSET_TABLEAtom(*_gotFile));
>>> -  _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc)
>>> GlobalOffsetTableAtom(*_gotFile));
>>> +  _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
>>>    result.push_back(std::move(_gotFile));
>>>    return true;
>>>  }
>>>
>>> Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h?rev=233401&r1=233400&r2=233401&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h
>>> (original)
>>> +++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h Fri
>>> Mar 27 14:33:05 2015
>>> @@ -27,9 +27,9 @@ protected:
>>>    createImplicitFiles(std::vector<std::unique_ptr<File>> &result) {
>>>      ExecutableWriter::createImplicitFiles(result);
>>>      _gotFile->addAtom(*new (_gotFile->_alloc)
>>> -                      GLOBAL_OFFSET_TABLEAtom(*_gotFile));
>>> +                      GlobalOffsetTableAtom(*_gotFile));
>>>      if (_ctx.isDynamic())
>>> -      _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));
>>> +      _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));
>>>      result.push_back(std::move(_gotFile));
>>>      return true;
>>>    }
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150327/d849db9f/attachment.html>

More information about the llvm-commits mailing list