[PATCH] R600/SI: Fix VOP2 VI encoding

Tom Stellard tom at stellard.net
Fri Mar 27 11:37:06 PDT 2015


On Fri, Mar 27, 2015 at 07:31:34PM +0100, Marek Olšák wrote:
> Ping. Do I have to ask for review of critical fixes like this one at all?
> 

No, post-commit review is fine for these.

LGTM.

-Tom

> Marek
> 
> On Tue, Mar 24, 2015 at 2:40 PM, Marek Olšák <maraeo at gmail.com> wrote:
> > From: Marek Olšák <marek.olsak at amd.com>
> >
> > Broken by "R600/SI: Refactor VOP2 instruction defs".
> > ---
> >  lib/Target/R600/SIInstrInfo.td | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Target/R600/SIInstrInfo.td b/lib/Target/R600/SIInstrInfo.td
> > index d603ecb..866e349 100644
> > --- a/lib/Target/R600/SIInstrInfo.td
> > +++ b/lib/Target/R600/SIInstrInfo.td
> > @@ -883,7 +883,7 @@ class VOP2_Real_si <string opName, vop2 op, dag outs, dag ins, string asm> :
> >    SIMCInstr <opName#"_e32", SISubtarget.SI>;
> >
> >  class VOP2_Real_vi <string opName, vop2 op, dag outs, dag ins, string asm> :
> > -  VOP2 <op.SI, outs, ins, opName#asm, []>,
> > +  VOP2 <op.VI, outs, ins, opName#asm, []>,
> >    SIMCInstr <opName#"_e32", SISubtarget.VI>;
> >
> >  multiclass VOP2SI_m <vop2 op, dag outs, dag ins, string asm, list<dag> pattern,
> > --
> > 2.1.0
> >
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list