[PATCH] [asan] Speed up interesting alloca checks

Kostya Serebryany kcc at google.com
Thu Mar 26 11:31:25 PDT 2015


This looks fine, but I would slightly prefer to compute the map beforehand instead of caching, if possible. 
I.e. instead of a map of  ProcessedAllocas have a set of InterestingAllocas that is computed in visitAllocaInst


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:811
@@ +810,3 @@
+
+  if (PreviouslySeenAllocaInfo != ProcessedAllocas.end()) {
+    return PreviouslySeenAllocaInfo->getSecond();
----------------
we tend to not write {} in such cases

http://reviews.llvm.org/D8639

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list