[PATCH] Add a way to enable/disable the ARM load/store optimization pass

Renato Golin renato.golin at linaro.org
Thu Mar 26 04:50:49 PDT 2015


Looks good to me. Just please, avoid using unnecessary curly brackets and add the comment to the boolean value before commit. Thanks!


================
Comment at: lib/Target/ARM/ARMTargetMachine.cpp:359
@@ +358,3 @@
+    if (EnableARMLoadStoreOpt) {
+      addPass(createARMLoadStoreOptimizationPass(true));
+    }
----------------
When this went in, the "true" value made a lot of sense, now, I'm failing to remember what was that all about. Can you add a comment like: (/* prealloc /* true)?

http://reviews.llvm.org/D8630

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list