[PATCH] llvm-link: Verify input modules

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Mar 25 16:25:16 PDT 2015


r233229
> On 2015-Mar-25, at 08:55, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
> 2011-08-22-ResolveAlias.ll is an insane leftover of the bogus way
> llvm-gcc used to implement weakref. Just nuke it.
> 
> LGTM
> 
> On 24 March 2015 at 23:03, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> This patch starts verifying input modules to `llvm-link`.  Otherwise,
>> broken input modules can cause assertions in `lib/Linker`.
>> 
>> I'm not sure what to do with test/Linker/2011-08-22-ResolveAlias.ll,
>> which fails like this:
>> 
>> Alias must point to a definition
>> i32 (i32*, void ()*)* @_ZL20__gthrw_pthread_oncePiPFvvE
>> Alias must point to a definition
>> i8* (i32)* @_ZL27__gthrw_pthread_getspecificj
>> ...
>> 
>> @Rafael, you touched it last :) -- any idea if we have sufficient
>> coverage for the underlying feature elsewhere?  Or should I update
>> the test?
>> 





More information about the llvm-commits mailing list