[PATCH] MC: For variable symbols, maintain MCSymbol::Section as a cache.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Mar 25 11:50:20 PDT 2015


>> For example, the fact that this patch changes the results in the MachO test concerns me. Why are the old values incorrect and the new ones correct? The first two changes look like it's a difference in order of what's in the object file, which is probably fine, but alias_to_local refers to __data now where before it did not. Why?
>
>
> The previous output showed that alias_to_local was given a section of 0, which was incorrect because a section value of 0 indicates that the symbol is defined externally. The new code correctly resolves the section to __data which is where alias_to_local's referent .Ltmp0 is defined.

Tim, you added this test with r209894 to support N_INDR. My
understanding is that this is the case of "N_INDR can't represent
this, produce *something*". Is that so?

Cheers,
Rafael




More information about the llvm-commits mailing list