[PATCH] Fix sancov.py to once again support big endian

Kostya Serebryany kcc at google.com
Tue Mar 24 17:36:15 PDT 2015


LGTM

Wow, I did not realize this is being tested on big-endian. 
Sorry for the breakage. (OTOH, I now know that this is indeed being tested on big-endian)


================
Comment at: projects/compiler-rt/lib/sanitizer_common/scripts/sancov.py:46
@@ +45,3 @@
+  if sys.byteorder == 'little':
+    idx=1
+  else:
----------------
maybe use 
  idx = 1 if sys.byteorder == 'little' else 0
or at least add spaces around =

http://reviews.llvm.org/D8594

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list