[gold] [PATCH] Add -m -m elf_x86_64 -plugin-opt=mtriple=x86_64-linux-gnu

H.J. Lu hjl.tools at gmail.com
Tue Mar 24 15:15:42 PDT 2015


On Tue, Mar 24, 2015 at 3:14 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> LGTM.
>
> Do you have commit access?

No, I don't.  Can you check it in for me?

Thanks.

> On 24 March 2015 at 18:03, H.J. Lu <hjl.tools at gmail.com> wrote:
>> On Tue, Mar 24, 2015 at 2:15 PM, Rafael Espíndola
>> <rafael.espindola at gmail.com> wrote:
>>> On 24 March 2015 at 17:04, H.J. Lu <hjl.tools at gmail.com> wrote:
>>>> On Tue, Mar 24, 2015 at 2:01 PM, Rafael Espíndola
>>>> <rafael.espindola at gmail.com> wrote:
>>>>> Instead of
>>>>>
>>>>>  -plugin-opt=mtriple=x86_64-linux-gnu
>>>>>
>>>>> Please make sure the files have a
>>>>>
>>>>> target triple = "x86_64-unknown-linux-gnu"
>>>>
>>>> I verified that all files this patch changes have
>>>>
>>>> target triple = "x86_64-unknown-linux-gnu"
>>>
>>> If so you don't need the "-plugin-opt=mtriple=x86_64-linux-gnu" change.
>>
>> Here is the updated patch.
>>
>>> Note that the triple might be missing from one of the Inputs/* files.
>>>
>>
>> They seem OK since there are gold test failures.
>>
>> Thanks.
>>
>> --
>> H.J.



-- 
H.J.




More information about the llvm-commits mailing list