[PATCH] [UBSan] Use shared library for UBSan on OS X (compiler-rt part).

Alexey Samsonov vonosmas at gmail.com
Mon Mar 23 16:12:58 PDT 2015


================
Comment at: make/platform/clang_darwin.mk:242
@@ -229,6 +241,3 @@
 SHARED_LIBRARY.asan_iossim_dynamic := 1
-# configure+make uses Clang, so we're using isysroot instead of --sysroot
-# or -Wl,-syslibroot.
-LDFLAGS.asan_iossim_dynamic := -undefined dynamic_lookup -install_name @rpath/libclang_rt.asan_iossim_dynamic.dylib \
-  -Wl,-ios_simulator_version_min,7.0.0 \
-  -mios-simulator-version-min=7.0 -isysroot $(IOSSIM_SDK)
+LDFLAGS.asan_iossim_dynamic := $(SANITIZER_LDFLAGS) -install_name @rpath/libclang_rt.asan_iossim_dynamic.dylib \
+  -Wl,-ios_simulator_version_min,7.0.0 $(SANITIZER_IOSSIM_DEPLOYMENT_ARGS)
----------------
zaks.anna wrote:
> I think we should pass -lc++ on all platforms to make sure we link against libc++.
Why do we then explicitly pass -stdlib=libc++ compile flags only on OS X, but not on iOS simulator? Could you somehow check if passing -stdlib=libc++ / -lc++ everywhere works?

http://reviews.llvm.org/D8473

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list