[PATCH] [Tsan] Do not sanitize memset() and other functions during initialization

Kostya Serebryany kcc at google.com
Mon Mar 23 12:52:34 PDT 2015


Is this fix testable? or is it covered by existing tests?


================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:667
@@ +666,3 @@
+  // On FreeBSD we get here from libthr internals on thread initialization.
+  if (cur_thread()->is_inited) {
+    SCOPED_TSAN_INTERCEPTOR(memset, dst, v, size);
----------------
I would prefer to define  COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED above this line and use  COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED here
and below instead of if(cur_thread()->is_inited)

http://reviews.llvm.org/D8543

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list