[PATCH] [aarch64] Distinguish the 'Q' and 'm' inline assembly memory constraints.

Daniel Sanders Daniel.Sanders at imgtec.com
Mon Mar 23 04:36:29 PDT 2015


Thanks. Committed in r232941.
________________________________________
From: Tim Northover [t.p.northover at gmail.com]
Sent: 20 March 2015 14:19
To: reviews+D8177+public+4bacf2ed33863b63 at reviews.llvm.org
Cc: Daniel Sanders; Amara Emerson; llvm-commits
Subject: Re: [PATCH] [aarch64] Distinguish the 'Q' and 'm' inline assembly memory constraints.

Hi Daniel,

On 18 March 2015 at 09:14, Daniel Sanders <daniel.sanders at imgtec.com> wrote:
> The main thing I'm looking for is for is for someone with knowledge of the target to say whether they're aware of any supported constraints that this patch doesn't cover.

Thanks for the patch, I think it looks fine. I wouldn't worry about
those 3-letter ones, hopefully no-one is using them. The trouble with
inline asm constraints is that on the GCC side, they're basically a
direct window into its internals so it's easy to use ones that are
simply meaningless in other compilers.

Tim.




More information about the llvm-commits mailing list