[llvm] r232917 - Prevent CHECK-NOTs from matching file paths

Duncan P. N. Exon Smith dexonsmith at apple.com
Sun Mar 22 08:58:22 PDT 2015


Author: dexonsmith
Date: Sun Mar 22 10:58:21 2015
New Revision: 232917

URL: http://llvm.org/viewvc/llvm-project?rev=232917&view=rev
Log:
Prevent CHECK-NOTs from matching file paths

A build directory with a name like `build-Werror` would hit a false
positive on these `CHECK-NOT`s before, since the actual error line looks
like:

    .../build-Werror/bin/llvm-as <stdin>:1:2: error: ...

Switch to using:

    CHECK-NOT: error:

(note the trailing semi-colon) to avoid matching almost any file path.

Modified:
    llvm/trunk/test/Assembler/invalid-generic-debug-node-tag-overflow.ll
    llvm/trunk/test/Assembler/invalid-mdcompileunit-language-overflow.ll
    llvm/trunk/test/Assembler/invalid-mdexpression-large.ll
    llvm/trunk/test/Assembler/invalid-mdlocation-overflow-column.ll
    llvm/trunk/test/Assembler/invalid-mdlocation-overflow-line.ll
    llvm/trunk/test/Assembler/invalid-mdsubrange-count-large.ll
    llvm/trunk/test/Assembler/invalid-mdsubrange-count-negative.ll

Modified: llvm/trunk/test/Assembler/invalid-generic-debug-node-tag-overflow.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-generic-debug-node-tag-overflow.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-generic-debug-node-tag-overflow.ll (original)
+++ llvm/trunk/test/Assembler/invalid-generic-debug-node-tag-overflow.ll Sun Mar 22 10:58:21 2015
@@ -1,6 +1,6 @@
 ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !0 = !GenericDebugNode(tag: 65535)
 
 ; CHECK: <stdin>:[[@LINE+1]]:29: error: value for 'tag' too large, limit is 65535

Modified: llvm/trunk/test/Assembler/invalid-mdcompileunit-language-overflow.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-mdcompileunit-language-overflow.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-mdcompileunit-language-overflow.ll (original)
+++ llvm/trunk/test/Assembler/invalid-mdcompileunit-language-overflow.ll Sun Mar 22 10:58:21 2015
@@ -1,6 +1,6 @@
 ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !0 = !MDCompileUnit(language: 65535,
                     file: !MDFile(filename: "a", directory: "b"))
 

Modified: llvm/trunk/test/Assembler/invalid-mdexpression-large.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-mdexpression-large.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-mdexpression-large.ll (original)
+++ llvm/trunk/test/Assembler/invalid-mdexpression-large.ll Sun Mar 22 10:58:21 2015
@@ -1,6 +1,6 @@
 ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !0 = !MDExpression(18446744073709551615)
 
 ; CHECK: <stdin>:[[@LINE+1]]:20: error: element too large, limit is 18446744073709551615

Modified: llvm/trunk/test/Assembler/invalid-mdlocation-overflow-column.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-mdlocation-overflow-column.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-mdlocation-overflow-column.ll (original)
+++ llvm/trunk/test/Assembler/invalid-mdlocation-overflow-column.ll Sun Mar 22 10:58:21 2015
@@ -2,7 +2,7 @@
 
 !0 = !{}
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !1 = !MDLocation(column: 65535, scope: !0)
 
 ; CHECK: <stdin>:[[@LINE+1]]:26: error: value for 'column' too large, limit is 65535

Modified: llvm/trunk/test/Assembler/invalid-mdlocation-overflow-line.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-mdlocation-overflow-line.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-mdlocation-overflow-line.ll (original)
+++ llvm/trunk/test/Assembler/invalid-mdlocation-overflow-line.ll Sun Mar 22 10:58:21 2015
@@ -2,7 +2,7 @@
 
 !0 = !{}
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !1 = !MDLocation(line: 4294967295, scope: !0)
 
 ; CHECK: <stdin>:[[@LINE+1]]:24: error: value for 'line' too large, limit is 4294967295

Modified: llvm/trunk/test/Assembler/invalid-mdsubrange-count-large.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-mdsubrange-count-large.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-mdsubrange-count-large.ll (original)
+++ llvm/trunk/test/Assembler/invalid-mdsubrange-count-large.ll Sun Mar 22 10:58:21 2015
@@ -1,6 +1,6 @@
 ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !0 = !MDSubrange(count: 9223372036854775807)
 
 ; CHECK: <stdin>:[[@LINE+1]]:25: error: value for 'count' too large, limit is 9223372036854775807

Modified: llvm/trunk/test/Assembler/invalid-mdsubrange-count-negative.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/invalid-mdsubrange-count-negative.ll?rev=232917&r1=232916&r2=232917&view=diff
==============================================================================
--- llvm/trunk/test/Assembler/invalid-mdsubrange-count-negative.ll (original)
+++ llvm/trunk/test/Assembler/invalid-mdsubrange-count-negative.ll Sun Mar 22 10:58:21 2015
@@ -1,6 +1,6 @@
 ; RUN: not llvm-as < %s -disable-output 2>&1 | FileCheck %s
 
-; CHECK-NOT: error
+; CHECK-NOT: error:
 !0 = !MDSubrange(count: -1)
 
 ; CHECK: <stdin>:[[@LINE+1]]:25: error: value for 'count' too small, limit is -1





More information about the llvm-commits mailing list