[lld] r232867 - [ELF] Dont add local symbols for dynamic lookup.

[Shankar Easwaran]

On 3/20/2015 7:06 PM, Chandler Carruth wrote:
> On Fri, Mar 20, 2015 at 4:47 PM, Shankar Easwaran <shankare at codeaurora.org>
> wrote:
>
>> [ELF] Dont add local symbols for dynamic lookup.
>>
>> Unable to add a unit test for this, as there is only one local undefined
>> symbol in regular shared libraries without a name.
>>
> I don't understand why you can't add a test here. This kind of change seems
> really easy to test? If it isn't something is completely broken with the
> testing infrastructure.
>
There is only one local symbol without a name and which is set to UNDEF 
in the dynamic symbol table. Its hard to create a testcase as how will 
you create a case that resolves with this symbol in the dynamic symbol 
table.

Let me know what you think, I tried few times by really creating a 
shared library with local symbols in the dynamic symbol table by 
creating an invalid dynamic library and that was only through lld :)

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation