[lld] r232862 - [ELF][X86_64] Remove relative references to include files

[Shankar Easwaran]

I dont see this pattern used in lld ELF or in llvm target directories of 
using relative paths.

On 3/20/2015 6:56 PM, Rui Ueyama wrote:
> Hmm, is this a good thing to do? ExampleSubTarget is really a
> sub-directory, so removing ".." doesn't make sense to me.
>
> On Fri, Mar 20, 2015 at 4:46 PM, Shankar Easwaran <shankare at codeaurora.org>
> wrote:
>
>> Author: shankare
>> Date: Fri Mar 20 18:46:56 2015
>> New Revision: 232862
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=232862&view=rev
>> Log:
>> [ELF][X86_64] Remove relative references to include files
>>
>> Modified:
>>      lld/trunk/lib/ReaderWriter/ELF/X86_64/CMakeLists.txt
>>
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleLinkingContext.h
>>
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.cpp
>>
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.h
>>      lld/trunk/lib/ReaderWriter/ELF/X86_64/Makefile
>>
>> Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/CMakeLists.txt?rev=232862&r1=232861&r2=232862&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/ELF/X86_64/CMakeLists.txt (original)
>> +++ lld/trunk/lib/ReaderWriter/ELF/X86_64/CMakeLists.txt Fri Mar 20
>> 18:46:56 2015
>> @@ -10,4 +10,6 @@ add_llvm_library(lldX86_64ELFTarget
>>       LLVMSupport
>>     )
>>
>> +include_directories(.)
>> +
>>   add_subdirectory(ExampleSubTarget)
>>
>> Modified:
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleLinkingContext.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleLinkingContext.h?rev=232862&r1=232861&r2=232862&view=diff
>>
>> ==============================================================================
>> ---
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleLinkingContext.h
>> (original)
>> +++
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleLinkingContext.h
>> Fri Mar 20 18:46:56 2015
>> @@ -10,8 +10,8 @@
>>   #ifndef
>> LLD_READER_WRITER_ELF_X86_64_EXAMPLE_TARGET_EXAMPLE_LINKING_CONTEXT
>>   #define
>> LLD_READER_WRITER_ELF_X86_64_EXAMPLE_TARGET_EXAMPLE_LINKING_CONTEXT
>>
>> -#include "../X86_64LinkingContext.h"
>> -#include "../X86_64TargetHandler.h"
>> +#include "X86_64LinkingContext.h"
>> +#include "X86_64TargetHandler.h"
>>
>>   namespace lld {
>>   namespace elf {
>>
>> Modified:
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.cpp?rev=232862&r1=232861&r2=232862&view=diff
>>
>> ==============================================================================
>> ---
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.cpp
>> (original)
>> +++
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.cpp
>> Fri Mar 20 18:46:56 2015
>> @@ -8,7 +8,7 @@
>>
>>   //===----------------------------------------------------------------------===//
>>
>>   #include "ExampleTargetHandler.h"
>> -#include "../X86_64ExecutableWriter.h"
>> +#include "X86_64ExecutableWriter.h"
>>   #include "ExampleLinkingContext.h"
>>
>>   using namespace lld;
>>
>> Modified:
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.h?rev=232862&r1=232861&r2=232862&view=diff
>>
>> ==============================================================================
>> ---
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.h
>> (original)
>> +++
>> lld/trunk/lib/ReaderWriter/ELF/X86_64/ExampleSubTarget/ExampleTargetHandler.h
>> Fri Mar 20 18:46:56 2015
>> @@ -10,7 +10,7 @@
>>   #ifndef
>> LLD_READER_WRITER_ELF_X86_64_EXAMPLE_TARGET_EXAMPLE_TARGET_HANDLER_H
>>   #define
>> LLD_READER_WRITER_ELF_X86_64_EXAMPLE_TARGET_EXAMPLE_TARGET_HANDLER_H
>>
>> -#include "../X86_64TargetHandler.h"
>> +#include "X86_64TargetHandler.h"
>>
>>   namespace lld {
>>   namespace elf {
>>
>> Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/Makefile
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/Makefile?rev=232862&r1=232861&r2=232862&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/lib/ReaderWriter/ELF/X86_64/Makefile (original)
>> +++ lld/trunk/lib/ReaderWriter/ELF/X86_64/Makefile Fri Mar 20 18:46:56 2015
>> @@ -10,7 +10,9 @@
>>   LLD_LEVEL := ../../../..
>>   LIBRARYNAME := lldX86_64ELFTarget
>>   USEDLIBS = lldCore.a
>> +
>>   CPP.Flags += -I$(PROJ_SRC_DIR)/$(LLD_LEVEL)/lib/ReaderWriter/ELF
>> +CPP.Flags += -I$(PROJ_SRC_DIR)/$(LLD_LEVEL)/lib/ReaderWriter/ELF/X86_64/
>>
>>   PARALLEL_DIRS := ExampleSubTarget
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation