[PATCH] Add support for AArch64 and ARM backends for v8.1 architecture extension.
t.p.northover at gmail.com
Fri Mar 20 14:39:56 PDT 2015
This looks like lots of different patches combined into one big one (across multiple Targets even!). It'd be better to split by individual features.
Entire backends have to be committed in one block, and we don't like that no matter how unavoidable it is. Feature extensions like this don't.
Comment at: lib/Target/AArch64/AArch64InstrFormats.td:8608
@@ +8607,3 @@
+ // FIXME: uncomment the following, after backend will support i16 neon type
+ //def : Pat<(i16 (Accum (i16 FPR16Op:$Rd),
+ // (i16 (vector_extract (v4i16
We don't usually put commented code in, and there's basically not the slightest hope that i16 is going to become a legal type in the current SelectionDAG framework.
More information about the llvm-commits