[PATCH] [compiler-rt] Add AtosSymbolizer and DlAddrSymbolizer as fallbacks for OS X

Alexey Samsonov vonosmas at gmail.com
Fri Mar 20 11:46:18 PDT 2015


Looks reasoable. Is sandbox-exec available on all Mac OS X systems?


================
Comment at: test/asan/TestCases/Darwin/dyld-root-path.cc:8
@@ +7,3 @@
+
+// CHECK: Using atos at user-specified path:
+
----------------
Please merge this test case into test/asan/TestCases/Darwin/atos-symbolizer.cc

================
Comment at: test/asan/TestCases/Darwin/sandbox-symbolizer.cc:12
@@ +11,3 @@
+
+// RUN: %clangxx_asan -O0 %s -o %t
+// RUN: not %run sandbox-exec -p '(version 1)(allow default)(deny mach-priv-task-port)' %t 2>&1 | FileCheck %s
----------------
You can reduce the number of compilations in this test:
first compile with -O0, then run two tests with sandbox-exec, then compile with -O3, then run two more tests with sandbox-exec.

http://reviews.llvm.org/D8285

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list