[PATCH] [MachineLICM] Sink instructions only if they are unlikely to be executed

Daniel Jasper djasper at google.com
Fri Mar 20 08:00:35 PDT 2015


Turns out the IsCopy check was actually important and papered over the fact that we cannot sink something that is used by a PHI (because we sink to before the first non-PHI instruction later). Sinking something that is used by a PHI probably also doesn't make much sense (or at least needs a separate investigation) as e.g. we might sink along the loop-entry edge.

Also simplified the implementation.


http://reviews.llvm.org/D8451

Files:
  lib/CodeGen/MachineLICM.cpp
  test/CodeGen/X86/sink-cheap-instructions.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8451.22347.patch
Type: text/x-patch
Size: 5950 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150320/5216b2c2/attachment.bin>


More information about the llvm-commits mailing list