[PATCH] [mips] [IAS] Improve warning for using AT with .set noat.

Toma Tabacu toma.tabacu at imgtec.com
Fri Mar 20 05:51:52 PDT 2015


Comments are inline.


================
Comment at: test/MC/Mips/set-at-directive-explicit-at.s:30
@@ -27,3 +29,3 @@
     jr    $1
-# WARNINGS-NOT: warning: used $at without ".set noat"
+# WARNINGS-NOT: warning: used $at (aka $1) without ".set noat"
 
----------------
I'm not sure if this CHECK is necessary.

================
Comment at: test/MC/Mips/set-at-directive-explicit-at.s:54
@@ -51,2 +53,2 @@
     jr    $16
 # WARNINGS-NOT: warning
----------------
I'm not sure if this CHECK is necessary, either.

http://reviews.llvm.org/D8479

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list