Should these x86 patches be integrated into the 3.6 release branch?

[Andrea Di Biagio]

Ok, I finished cherry-picking the changes from trunk into release_36.

* Merged trunk revision 231601 into branches/release_36 at revision 232803
* Merged trunk revision 232046 into branches/release_36 at revision 232804
* Merged trunk revision 231219 into branches/release_36 at revision 232807

Thanks,
Andrea

On Thu, Mar 19, 2015 at 7:55 PM, Andrea Di Biagio
<andrea.dibiagio at gmail.com> wrote:
> Thanks all,
> I have just merged trunk r232179 into branches/release_36 at revision 232753.
>
> I plan to merge the three remaining changes tomorrow.
>
> Thanks,
> Andrea
>
> On Thu, Mar 19, 2015 at 5:22 PM, Tom Stellard <tom at stellard.net> wrote:
>> LGTM, go ahead and merge these into the 3.6 branch.
>>
>> -Tom
>>
>> On Thu, Mar 19, 2015 at 10:07:51AM -0700, Nadav Rotem wrote:
>>> SGTM. I think it is a good idea to take these changes to the release branch.
>>>
>>>
>>> > On Mar 19, 2015, at 10:02 AM, Quentin Colombet <qcolombet at apple.com> wrote:
>>> >
>>> > Hi Andrea,
>>> >
>>> > SGTM, but technically Nadav is the code owner.
>>> > Nadav, thoughts?
>>> >
>>> > Cheers,
>>> > -Quentin
>>> >> On Mar 19, 2015, at 4:45 AM, Andrea Di Biagio <andrea.dibiagio at gmail.com> wrote:
>>> >>
>>> >> Hi Quentin, Nadav and all,
>>> >>
>>> >> I am not familiar with the release process so, sorry for the long post.
>>> >> In the last few weeks I committed at least three patches to fix bad
>>> >> codegen issues affecting x86 only. Here is the list of commits:
>>> >>
>>> >> - http://llvm.org/viewvc/llvm-project?view=revision&revision=232179
>>> >> - http://llvm.org/viewvc/llvm-project?view=revision&revision=231601
>>> >> - http://llvm.org/viewvc/llvm-project?view=revision&revision=232046
>>> >>
>>> >> The first two commits fix problems in the new shuffle lowering, while
>>> >> the last commit (r232046) fixes a problem in a target specific combine
>>> >> on SETCC nodes.
>>> >>
>>> >> There is also another important patch committed by Michael at revision
>>> >> 231219 which fixes a regression introduced at revision 224759.
>>> >> Here is the link to his commit:
>>> >> - http://llvm.org/viewvc/llvm-project?view=revision&revision=231219
>>> >>
>>> >> I haven't tested the 3.6 branch myself, however it is very likely that
>>> >> these bugs are present in the 3.6 branch. Given that all these fixes
>>> >> would resolve bad codegen issues, I suggest you consider whether these
>>> >> should be integrated into the 3.6 branch.
>>> >>
>>> >> I hope this information was useful. I don't know enough about the
>>> >> release process, so I just wanted to make sure that people are aware
>>> >> of these fixes.
>>> >>
>>> >> Thanks,
>>> >> Andrea
>>> >
>>>