[PATCH] [compiler-rt] Add AtosSymbolizer and DlAddrSymbolizer as fallbacks for OS X

[Alexey Samsonov]

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:421
@@ +420,3 @@
+  if (path && path[0] == '\0') {
+    VReport(2, "External symbolizer is explicitly disabled.\n");
+  } else if (!internal_strcmp(binary_name, "llvm-symbolizer")) {
----------------
return nullptr here

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:431
@@ +430,3 @@
+    Report("ERROR: Using `atos` is only supported on Darwin.\n");
+    CHECK("atos on non-darwin" && 0);
+#endif  // SANITIZER_MAC
----------------
Just write Die() here.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:440
@@ +439,3 @@
+           "binary or other known tool.\n", path);
+    CHECK("unknown symbolizer" && 0);
+  } else {
----------------
Die()

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:442
@@ +441,3 @@
+  } else {
+    // Otherwise symbolizer program is unknown, let's search $PATH
+    CHECK(path == nullptr);
----------------
No need for else{}

http://reviews.llvm.org/D8285

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/