[Patch] Don't declare all text sections at the start of the .s

Eric Christopher echristo at gmail.com
Thu Mar 19 13:33:27 PDT 2015


Few comments:

a) why not virtual and override for ChangeSection?
b) every where you pass true/false to createObjectStreamer you should
comment what it is,
c) Is there a way to just subclass the mach-o MCObjectStreamer to avoid the
boolean?

-eric

On Thu, Mar 19, 2015 at 7:30 AM Rafael EspĂ­ndola <rafael.espindola at gmail.com>
wrote:

> A version with explicit section names and more comments is attached.
>
> I think this addresses all concerns:
>
> * I can bootstrap with debug info on X86_64.
> * It can be used to build some objc to arm.
> * If a non-whitelisted section is created after dwarf, we assert.
>
> The white listed sections are the one that the assembler itself
> creates at the end of the file.
>
> OK?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150319/ce1a99fd/attachment.html>


More information about the llvm-commits mailing list